Canceling language selector should not popup an error

Jul 20, 2011 at 1:22 PM
Edited Jul 20, 2011 at 1:26 PM

Dear developers, we are very much obliged to you for dotNetInstaller!

We have using the product to support multilingual installing of our's Advanced IP Scanner.

Very useful, but some days ago our testing team reported disappointing bug, "Install: strange message box showed when clicking 'Cancel' in the language selector dialog".

We are much focused on easy-to-use user experience, and that strange behavior is very annoying for some users.

What deal about the issue?

For an example, Inno Setup shows the same language selection dialog just closed by 'Cancel' button.

Coordinator
Jul 20, 2011 at 11:02 PM

What "strange" error are you seeing "sometimes"? Are you sure it's the same problem as the issue you've linked? What does the strange error say?

Jul 21, 2011 at 9:00 AM

Yes, that's the same issue. There is 'Language selection cancelled by user' text in the message box. And we saw it everytime after pressing 'Cancel' button. It is "strange" for user, but obvious for us; moreover, we are familiar with code that is responsible for that behavior - but we can't find the means of doing it, because the message box pops up after an exception thrown. Your design - your solution. Please!

Coordinator
Jul 21, 2011 at 12:57 PM

I would add a specific exception type (eg. UserCancelledException) and ignore it explicitly if some (new) option is set. Feel free to implement it and send a patch.

Aug 3, 2011 at 6:34 PM

Build FAILED.

e:\trunk\thirdparty\cab\cabinet\compress.hpp(433): warning C4244: 'argument' : conversion from 'Cabinet::CCompress::eCompress' to 'TCOMP', possible loss of data

e:\trunk\thirdparty\cab\cabinet\compress.hpp(433): warning C4244: 'argument' : conversion from 'Cabinet::CCompress::eCompress' to 'TCOMP', possible loss of data

c:\program files\microsoft visual studio 8\vc\atlmfc\include\atlsimpstr.h(726): fatal error C1085: Cannot write precompiled header file: 'Debug\dotNetInstallerToolsLib.pch': The parameter is incorrect.

.\LibExtract.cpp(7): fatal error C1033: cannot open program database 'e:\trunk\thirdparty\cablib\debug\vc80.idb'

.\LibCompress.cpp(7): fatal error C1033: cannot open program database 'e:\trunk\thirdparty\cablib\debug\vc80.idb'

.\AssemblyInfo.cpp(1): fatal error C1033: cannot open program database 'e:\trunk\thirdparty\cablib\debug\vc80.idb'

e:\trunk\unittests\cppunittestsrunner\cppunittestfunctionexectimer.cpp(1): fatal error C1033: cannot open program database 'e:\trunk\unittests\cppunittestsrunner\debug\vc80.idb'

e:\trunk\unittests\cppunittestsrunner\cppunittestrunner.cpp(1): fatal error C1033: cannot open program database 'e:\trunk\unittests\cppunittestsrunner\debug\vc80.idb'

c:\program files\microsoft visual studio 8\vc\atlmfc\include\atlsimpstr.h(726): fatal error C1085: Cannot write precompiled header file: 'Debug\dotNetInstallerLib.pch': The parameter is incorrect.

c:\program files\microsoft visual studio 8\vc\atlmfc\include\atlsimpstr.h(726): fatal error C1085: Cannot write precompiled header file: 'Debug\Cab.pch': The parameter is incorrect.

   2 Warning(s)

   8 Error(s)

Coordinator
Aug 3, 2011 at 7:15 PM

You need visual studio 2005 for DNI, or you're on your own - I have no idea why VS 2008 fails to generate the PCH.

Aug 3, 2011 at 7:24 PM

That's VS 2005 :-(

Coordinator
Aug 3, 2011 at 7:28 PM

Sorry, got confused by the VS 8 in the path. You'll have to fight this a bit yourself, it just fails to write a precompiled header - google has a bunch of hits on this.

Aug 4, 2011 at 12:35 PM

Thanks! That's just something like recruit training :-) Hackers are alive!